v3.2: Support nested multipart with nested Encoding Objects #4747
+85
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the Media Type Object's encoding field to the Encoding Object to support nested multipart documents. It only requires one level of nesting, but allows implementations to support more.
handrews
added
the
media and encoding
|
Oh come on, we can do full recursion ;) |
This was referenced Jul 4, 2025
ralfhandl
requested changes
Jul 17, 2025
ralfhandl
previously approved these changes
Jul 19, 2025
|
@ralfhandl with apologies, you'll have to hit the review button again- I stripped out the line requiring documentation of nesting level limitations as documentation requirements proved controversial on another PR. Which I still find baffling but at this point I just want the changes in and don't want to argue about the documentation stuff. |
miqui
approved these changes
Jul 20, 2025
ralfhandl
approved these changes
Jul 20, 2025
This was referenced Jul 20, 2025
ralfhandl
reviewed
Jul 22, 2025
ralfhandl
reviewed
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #4589, both of the most in-depth reviewers (@jeremyfiel and @ralfhandl) requested support for nested
multipart/mixedwith real-world use cases.This adds the Media Type Object's three encoding fields to the Encoding Object to support nested multipart documents. It only requires one level of nesting, but allows implementations to support more, which seemed like a reasonable compromise as a fully-recursive system is quite complex.
This PR relies on PR #4743 to address the complexities of correlating Encoding Objects and Schema Objects, and determining the instance type in order to properly default
contentType.